feat: add isDuration validator for duration strings#2802
Open
SarthakDudhe wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| export default function isDuration(str) { | ||
| assertString(str); | ||
| const match = str.match(durationRegex); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 115 +1
Lines 2587 2601 +14
Branches 656 659 +3
=========================================
+ Hits 2587 2601 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDuration: Added a new validator that checks if a string is a valid duration format matching Vercel's ms package. It supports positive/negative decimals and integers, with optional spaces and standard duration units (e.g., days, hours, min, sec, ms, etc.).
Registration & Docs: Added isDuration to the entry point src/index.js and documented it in README.md.
Tests: Added a unit test block in test/validators.test.js to cover valid (e.g., '1.5 hours', '100ms') and invalid (e.g., '123 Yards', 'abc') patterns.